[release-ocm-2.17] ACM-38018: CVE-2026-42306 Bump assisted-service dep to pick up docker v28.5.2 - #1562
Conversation
|
@shay23bra: This pull request references ACM-38018 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
Bot
added
the
size/XXL
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shay23bra The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-ocm-2.17 #1562 +/- ##
=================================================
Coverage 55.83% 55.83%
=================================================
Files 89 89
Lines 4508 4508
=================================================
Hits 2517 2517
Misses 1801 1801
Partials 190 190 🚀 New features to boost your workflow:
|
The Dockerfile already builds with GOFLAGS=-mod=mod. Align unit tests to use the same mode, avoiding issues with vendored packages that have subdirectories matching .gitignore patterns (e.g. build/).
|
/retest |
|
@shay23bra: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The vendored docker/docker v28.5.2 includes an api/types/build sub-package that conflicts with .gitignore build rule. Use -mod=mod for all Go build and test commands to resolve dependencies from the module cache instead of the incomplete vendor directory.
2 participants
Bump assisted-service dependency to latest commit which includes docker/docker v28.5.2, fixing CVE-2026-42306.